-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UX] Add empty states #80904
Merged
Merged
[UX] Add empty states #80904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinkambic
added
bug
Fixes for quality problems that affect the customer experience
v8.0.0
Team:Uptime - DEPRECATED
Synthetics & RUM sub-team of Application Observability
v7.10.0
v7.11.0
labels
Oct 16, 2020
Pinging @elastic/uptime (Team:uptime) |
Pinging @elastic/apm-ui (Team:apm) |
justinkambic
added
the
release_note:skip
Skip the PR/issue when compiling release notes
label
Oct 16, 2020
justinkambic
force-pushed
the
ux_empty-states
branch
from
October 19, 2020 17:39
d6515ba
to
3d1508a
Compare
justinkambic
force-pushed
the
ux_empty-states
branch
from
October 19, 2020 22:41
e7c6cbe
to
cc03dc9
Compare
💚 Build SucceededMetrics [docs]async chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
andrewvc
approved these changes
Oct 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
Oct 20, 2020
* Add empty state for user experience metrics. * Add empty state for page load duration metrics. * Add empty state for core web vitals. * Fix bug injected by these changes. * Add a test.
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
Oct 20, 2020
* Add empty state for user experience metrics. * Add empty state for page load duration metrics. * Add empty state for core web vitals. * Fix bug injected by these changes. * Add a test.
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 20, 2020
* master: (64 commits) Rename Security Solution Bug Template (elastic#81187) Update links (elastic#81125) Specify format for date range query (elastic#81025) [Alerting] Improve toast when alert is created (elastic#80327) [UX] Add empty states (elastic#80904) Add TS config for kibana_legacy (elastic#80992) [Telemetry] Add method to enable endpoint security data usage example (elastic#80940) [Alerting] Add scoped cluster client to alerts and actions services (elastic#80794) Fix reactRouterNavigate when used with a string (elastic#80520) [Security Solution] [Detections] Read privileges for dependencies (elastic#80852) [ML] Fixing exclude frequent in advanced wizard (elastic#81121) Fix security solution template label (elastic#80976) [DOCS] Update index management docs (elastic#80893) [APM] Error rate on service list page is not in sync with the value at the transaction page (elastic#80814) skip flaky suite (elastic#81072) [Task Manager] Cleans up legacy plugin structure (elastic#80381) Support unsigned_long fields (elastic#81115) [Form lib] Export internal state instead of raw state (elastic#80842) [Lens] Add toast notification when visualization is saved (elastic#80788) Index pattern edit field formatter API (elastic#78352) ...
justinkambic
added a commit
that referenced
this pull request
Oct 20, 2020
justinkambic
added a commit
that referenced
this pull request
Oct 20, 2020
Backported to:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Fixes for quality problems that affect the customer experience
release_note:skip
Skip the PR/issue when compiling release notes
Team:APM
All issues that need APM UI Team support
Team:Uptime - DEPRECATED
Synthetics & RUM sub-team of Application Observability
v7.10.0
v7.11.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #79419.
Adds initial empty states for when data is not present in the UX dashboard metrics and vitals fields.
Before
After
Testing this PR
Load up an empty Kibana/ES stack and ensure that the fields display N/A and greyed-out states in place of stacked core vitals fields, as seen in the "After" image above.
Compare against OBLT and make sure that the metrics and vitals continue to display as designed:
Checklist
Delete any items that are not applicable to this PR.
For maintainers